| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, walther(at)technowledgy(dot)de, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fixing CREATEROLE |
| Date: | 2023-01-03 20:11:47 |
| Message-ID: | CA+TgmobFzTLkLwOquFrAcdsWBsOWDr-_H-jw+qBvfx-wSzMwDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 23, 2022 at 4:55 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Dec 22, 2022 at 9:14 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > The contents looks good to me other than that problem, and I agree to
> > backpatch it.
>
> Cool. Thanks for the review.
>
> > Why did you choose to use two dots for ellipses in some command
> > <literal>s rather than three? I know I've made that choice too on
> > occassion, but there aren't many such cases and maybe we should put a
> > stop to it (or a period) before it spreads too much.
>
> Honestly, I wasn't aware that we had some other convention for it.
Committed and back-patched 0001 with fixes for the issues that you pointed out.
Here's a trivial rebase of the rest of the patch set.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Refactor-permissions-checking-for-role-grants.patch | application/octet-stream | 6.8 KB |
| v3-0004-Add-new-GUC-createrole_self_grant.patch | application/octet-stream | 11.0 KB |
| v3-0002-Pass-down-current-user-ID-to-AddRoleMems-and-DelR.patch | application/octet-stream | 6.8 KB |
| v3-0003-Restrict-the-privileges-of-CREATEROLE-users.patch | application/octet-stream | 34.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-03 20:14:00 | Re: enable_timeout_every() and fin_time |
| Previous Message | Andres Freund | 2023-01-03 20:05:20 | Re: postgres_fdw uninterruptible during connection establishment / ProcSignalBarrier |