Re: Tab completion for TABLESAMPLE

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Tab completion for TABLESAMPLE
Date: 2015-06-22 18:16:03
Message-ID: CA+Tgmob=u4yVfDnBR6bGj=vbT2y1PGu0WNDsvx-nCN=Ddm9QJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 19, 2015 at 4:01 PM, Brendan Jurd <direvus(at)gmail(dot)com> wrote:
> On Fri, 19 Jun 2015 at 21:05 Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
>>
>> On 2015-06-19 09:08, Brendan Jurd wrote:
>> > I
>> > think it would be convenient and user-friendly to complete the opening
>> > bracket -- it would make it perfectly clear that an argument is required
>> > for the syntax to be valid.
>> >
>>
>> Agreed, here is updated version which does that.
>
>
> Thanks Petr, I have tested your v2 and it works well. This is ready for
> committer.

Committed, thanks.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-06-22 18:16:58 Re: pg_receivexlog --create-slot-if-not-exists
Previous Message David G. Johnston 2015-06-22 17:59:12 Re: RFC: replace pg_stat_activity.waiting with something more descriptive