| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_plan_advice |
| Date: | 2026-03-16 16:52:55 |
| Message-ID: | CA+TgmoanOwxP=VcCfs6kv3tyrwVamesLBna9LzoF=B4=7wa0kQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 14, 2026 at 11:06 AM Zsolt Parragi
<zsolt(dot)parragi(at)percona(dot)com> wrote:
> I noticed a difference between installed headers with make and meson,
> which is caused by pg_plan_advice.h. It is completely missing from the
> make build, and installs to the wrong location with meson.
>
> Please see the attached patch that fixes this.
Thanks. The changes to the Makefile seem to mirror what is done in
contrib/isn/Makefile, but I'm not so sure about the meson.build
changes. sepgsql uses dir_data / 'contrib' rather than
dir_include_server. src/pl/pl{perl,pgsql,python} use
dir_include_server, but they also live in src/pl, not contrib. I don't
think I understand what the underlying principal is supposed to be
here. If you or anyone else knows, please enlighten me.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-03-16 17:11:16 | Re: pg_plan_advice |
| Previous Message | Masahiko Sawada | 2026-03-16 16:46:19 | Re: POC: Parallel processing of indexes in autovacuum |