| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Robins Tharakan <tharakan(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Subject: | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Date: | 2017-09-12 14:36:55 |
| Message-ID: | CA+TgmoahiBm1RUk8Cv7njbW3FPx5JQoen8-u_e-n=9a=ObVcQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 11, 2017 at 6:41 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Mon, Sep 11, 2017 at 11:43 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> So I think this is just an excuse for turning --no-security-labels
>> into --no-object-property=security-label. To me, that's just plain
>> worse.
>
> It does not seem that my thoughts here have been correctly transmitted
> to your brain.
Dang, we really should have put more work into that inter-brain link.
PostgreSQL group mind FTW!
> I do not mean to change the user-facing options, just
> to refactor the code internally so as --no-foo switches can be more
> easily generated, added and handled as they are associated with an
> object type. A portion of the complains is caused by the fact that a
> lot of similar code is duplicated.
Ah, well. No objection to refactoring away duplicate code, of course.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-09-12 14:38:12 | Re: [JDBC] Channel binding support for SCRAM-SHA-256 |
| Previous Message | Alvaro Herrera | 2017-09-12 14:34:26 | Re: Automatic testing of patches in commit fest |