From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Why does pgindent's README say to download typedefs.list from the buildfarm? |
Date: | 2024-05-15 16:06:03 |
Message-ID: | CA+Tgmoacj1F=h6HQocSo7btsYDE7Sh+9Lz-g=uZpDMFUVMeCjQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 23, 2024 at 4:05 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> Here is a first attempt. I'm not tremendously happy with it, but it at
> least gets something on the page to build on. I was originally going to
> copy/paste the relevant steps into the description of the incremental
> process, but that seemed kind-of silly, so I instead just pointed to the
> relevant steps of the "full" process, along with the deviations from those
> steps. That's a little more work for the reader, but maybe it isn't too
> bad... I plan to iterate on this patch some more.
What jumps out at me when I read this patch is that it says that an
incremental run should do steps 1-3 of a complete run, and then
immediately backtracks and says not to do step 2, which seems a little
strange.
I played around with this a bit and came up with the attached, which
takes a slightly different approach. Feel free to use, ignore, etc.
--
Robert Haas
EDB: http://www.enterprisedb.com
Attachment | Content-Type | Size |
---|---|---|
pgindent_readme_v2.patch | application/octet-stream | 2.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Sriram RK | 2024-05-15 16:22:10 | Re: AIX support |
Previous Message | Noah Misch | 2024-05-15 15:52:41 | Re: AIX support |