Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Vladimir Rusinov <vrusinov(at)google(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Date: 2017-01-26 17:21:08
Message-ID: CA+TgmoZEshAGs=_m2_TGmQ-fKkfjwj0MASQ6upT+DZHBVLD24Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Tue, Jan 24, 2017 at 4:47 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> But I don't see any proposals to actually change all uses of "xlog" to
>> "wal". What about program names, command line options, etc.? If the
>> argument is, we changed one thing, we should change the rest, then let's
>> see that. I think that argument itself is flawed, but if that's what
>> we're going with, let's see the whole plan.
>
> I'm happy to go change every last bit of it. I was expecting after I
> committed the initial rename that somebody would provide a follow-on
> patch to do the rest of it in short order. Instead, months went by
> and we still don't have a complete patch. But I don't see why that
> has to take more than a day's work, probably just a few hours. I'd
> like to do that and move on.

And here are patches for that.

0001 renames everything that contains "xlog" in pg_proc.h to refer to "wal".

0002 renames programs whose names contains "xlog".

0003 renames the dtrace probes whose names contain "xlog".

0004 renames command line options which contain "xlog".

There are probably a few more things that could be done afterwards to
clean up other odds and ends, but I think this gets the vast bulk of
the user-visible references to xlog.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
0001-Remove-all-references-to-xlog-from-SQL-callable-func.patch invalid/octet-stream 52.9 KB
0002-Rename-user-facing-tools-with-xlog-in-the-name-to-sa.patch invalid/octet-stream 723.4 KB
0003-Rename-dtrace-probes-for-ongoing-xlog-wal-conversion.patch invalid/octet-stream 3.0 KB
0004-Rename-command-line-options-for-ongoing-xlog-wal-con.patch invalid/octet-stream 6.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-01-26 17:24:44 Re: Allow interrupts on waiting standby
Previous Message Robert Haas 2017-01-26 17:09:05 Re: [COMMITTERS] pgsql: Reindent table partitioning code.