Re: [COMMITTERS] pgsql: Reindent table partitioning code.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Reindent table partitioning code.
Date: 2017-01-26 17:09:05
Message-ID: CA+TgmoY-7RQ6+WqR_3pd6i=m8t+qJDYx30eG7RzB71GHB0Z8cQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Jan 26, 2017 at 10:16 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 1/24/17 10:51 AM, Robert Haas wrote:
>> On Tue, Jan 24, 2017 at 10:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>>>> Reindent table partitioning code.
>>>
>>> Oh, thank you, I was starting to get annoyed with that too.
>>
>> Glad you like. The pgindent damage introduced by the logical
>> replication commits is even more extensive, but I didn't want to touch
>> that without discussion. Peter might want to look for a time when not
>> too many patches are pending to do something similar, though.
>
> Can you give me an example of a file or area that looks bad now?

What I did was just run pgindent on the whole tree and then undid all
the stuff that was unrelated to table partitioning with 'git checkout'
and/or 'git checkout -p'.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-01-26 17:18:21 pgsql: Ensure that a tsquery like '!foo' matches empty tsvectors.
Previous Message Fujii Masao 2017-01-26 15:43:12 pgsql: Fix typo in description for pg_replication_origin_advance functi

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-01-26 17:21:08 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Previous Message Peter Eisentraut 2017-01-26 15:16:35 Re: [COMMITTERS] pgsql: Reindent table partitioning code.