| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: cross-platform pg_basebackup |
| Date: | 2022-10-20 18:47:21 |
| Message-ID: | CA+TgmoZ9AM29s0VPEGmx7Bmm5NG-rTaMDGDrvvrVinj2D0kCLA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 20, 2022 at 1:28 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > Cool. Here's a patch.
>
> LGTM, except I'd be inclined to ensure that all the macros
> are function-style, ie
>
> +#define IS_DIR_SEP(ch) IS_NONWINDOWS_DIR_SEP(ch)
>
> not just
>
> +#define IS_DIR_SEP IS_NONWINDOWS_DIR_SEP
>
> I don't recall the exact rules, but I know that the second style
> can lead to expanding the macro in more cases, which we likely
> don't want. It also seems like better documentation to show
> the expected arguments.
OK, thanks. v2 attached.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_basebackup-Fix-cross-platform-tablespace-reloc.patch | application/octet-stream | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-10-20 18:51:21 | Re: Avoid memory leaks during base backups |
| Previous Message | Jacob Champion | 2022-10-20 18:36:34 | Re: [PoC] Let libpq reject unexpected authentication requests |