Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Cool. Here's a patch.
LGTM, except I'd be inclined to ensure that all the macros
are function-style, ie
+#define IS_DIR_SEP(ch) IS_NONWINDOWS_DIR_SEP(ch)
not just
+#define IS_DIR_SEP IS_NONWINDOWS_DIR_SEP
I don't recall the exact rules, but I know that the second style
can lead to expanding the macro in more cases, which we likely
don't want. It also seems like better documentation to show
the expected arguments.
regards, tom lane