Re: Compilation on Debian SID

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Olly Betts <olly(at)survex(dot)com>
Cc: pgadmin-hackers(at)postgresql(dot)org, Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Subject: Re: Compilation on Debian SID
Date: 2011-11-28 17:40:33
Message-ID: CA+OCxoz3=KaQ13y_3TmOkLZp8amhVkXxQxoaczgP9rYYk4UpOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Sat, Nov 26, 2011 at 11:05 PM, Olly Betts <olly(at)survex(dot)com> wrote:
> On Sat, Nov 26, 2011 at 08:18:31PM +0000, Dave Page wrote:
>>
> This isn't original wx code - a number of projects define equivalent
> macros (and often with the same names, which is where the problems lie
> when they do it in API headers and you want to use two or more such
> projects at once).
>
> So just find one with a licence that's compatible:

The irony is that on closer examination we don't actually need the
macro at all, as in a Unicode build of wxWidgets (pgAdmin requires
Unicode support), it gets defined away to nothing. So, the patch ends
up looking like the attached.

Guillaume, please give it a quick check in case I missed anything.

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
attribute_printf.diff application/octet-stream 572 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Olly Betts 2011-11-28 23:34:28 Re: Compilation on Debian SID
Previous Message Dave Page 2011-11-28 09:56:37 Re: Compilation on Debian SID