Re: d25ea01275 and partitionwise join

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Richard Guo <riguo(at)pivotal(dot)io>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: d25ea01275 and partitionwise join
Date: 2020-04-06 15:19:21
Message-ID: CA+HiwqHbiUi8V7=vJm3rLazkyqFabXNJWLuOr4XnYUDFR+2bGw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Apr 6, 2020 at 11:09 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Langote <amitlangote09(at)gmail(dot)com> writes:
> > Oops, I thought I copy-pasted 4-way full join test not this one, but
> > evidently didn't.
>
> Have you got such a query at hand? I wondered whether we shouldn't
> use a 4-way rather than 3-way test case; it'd offer more assurance
> that nesting of these things works.

Hmm, I just did:

-SELECT COUNT(*) FROM prt1 FULL JOIN prt2 p2(b,a,c) USING(a,b) FULL
JOIN prt2 p3(b,a,c) USING (a, b)
+SELECT COUNT(*) FROM prt1 FULL JOIN prt2 p2(b,a,c) USING(a,b) FULL
JOIN prt2 p3(b,a,c) USING (a, b) FULL JOIN prt1 p4 (a,b,c) USING (a,
b)

which does succeed in using partitionwise join. Please see attached
delta that applies on your v7 if that is what you'd rather have.

--
Thank you,

Amit Langote
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v7-test-delta.patch application/octet-stream 7.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-04-06 16:31:09 Re: WAL usage calculation patch
Previous Message Robert Haas 2020-04-06 15:13:24 Re: where should I stick that backup?