Re: A reloption for partitioned tables - parallel_workers

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Seamus Abshere <seamus(at)abshere(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A reloption for partitioned tables - parallel_workers
Date: 2021-03-18 13:06:33
Message-ID: CA+HiwqFC+F79dG7T3JzmBGX66cs3dvFvaTzgt=7PYSKTBSB9vA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 5, 2021 at 11:06 PM Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> wrote:
> On Fri, 2021-03-05 at 22:55 +0900, Amit Langote wrote:
> > On Fri, Mar 5, 2021 at 10:47 PM Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> wrote:
> > > On Wed, 2021-03-03 at 17:58 +0900, Amit Langote wrote:
> > > > For example, with the attached PoC patch:
> > >
> > > I have incorporated your POC patch and added a regression test.
> > >
> > > I didn't test it thoroughly though.
> >
> > Thanks. Although, I wonder if we should rather consider it a
> > standalone patch to fix a partition planning code deficiency.
>
> Oh - I didn't realize that your patch was independent.

Attached a new version rebased over c8f78b616, with the grouping
relation partitioning enhancements as a separate patch 0001. Sorry
about the delay.

I'd also like to change compute_append_parallel_workers(), as also
mentioned upthread, such that disabling Parallel Append by setting
parallel_workers=0 on a parent partitioned table does not also disable
the partitions themselves being scanned in parallel even though under
an Append. I didn't get time today to work on that though.

--
Amit Langote
EDB: http://www.enterprisedb.com

Attachment Content-Type Size
v5-0001-Mark-fully-grouped-relations-partitioned-if-input.patch application/octet-stream 2.3 KB
v5-0002-Allow-setting-parallel_workers-on-partitioned-tab.patch application/octet-stream 16.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2021-03-18 13:07:41 Re: CDC feature request
Previous Message Stepan Yankevych 2021-03-18 13:03:17 CDC feature request