| From: | Amit Langote <amitlangote09(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Performance Improvement For Copy From Binary Files |
| Date: | 2020-07-15 02:32:58 |
| Message-ID: | CA+HiwqEKHz-=GqD3jx9suk83yfDv_ivM_3ZfCeu6koQCet9Sjw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Vignesh,
On Tue, Jul 14, 2020 at 10:23 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> On Tue, Jul 14, 2020 at 11:19 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > Sounds fine to me. Although CopyLoadRawBuf() does not seem to a
> > candidate for rigorous code optimization as it does not get called
> > that often.
>
> I thought we could include that change as we are making changes around
> that code.
Sure, done.
> Rest of the changes looked fine to me. Also I noticed that
> commit message was missing in the patch.
Please see the attached v7.
--
Amit Langote
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Improve-performance-of-binary-COPY-FROM-with-buff.patch | application/octet-stream | 10.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2020-07-15 02:34:05 | Re: WIP: BRIN multi-range indexes |
| Previous Message | Tom Lane | 2020-07-15 02:28:48 | Re: Binary support for pgoutput plugin |