From: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, Przemysław Sztoch <przemyslaw(at)sztoch(dot)pl> |
Subject: | Re: encode/decode support for base64url |
Date: | 2025-08-06 19:42:48 |
Message-ID: | CA+v5N40HH=B_-qxBXbRXvNiy3Qr8eMNTpjwC7tah_=ryQ-_w0w@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 6, 2025 at 4:34 PM Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
wrote:
> Attaching v6 again because it wasn't picked up the last time.
> Trying from Gmail's web page this time.
>
>
>
> On Tue, Aug 5, 2025 at 12:40 PM Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
> wrote:
>
>>
>>
>> On 1 Aug 2025, at 1:13 PM, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
>> wrote:
>>
>>
>> On Tue, Jul 29, 2025 at 3:25 PM Daniel Gustafsson <daniel(at)yesql(dot)se>
>> wrote:
>>
>>> > On 12 Jul 2025, at 21:40, David E. Wheeler <david(at)justatheory(dot)com>
>>> wrote:
>>>
>>> > Thank you! This looks great. The attached revision makes a a couple of
>>> minor changes:
>>>
>>> I also had a look at this today and agree that it looks pretty close to
>>> being
>>> done, and a feature we IMHO would like to have.
>>
>>
>> Thanks for having a look Daniel!
>>
>>
>>>
>>>
>> The attached version also adds a commit message, tweaks the documentation
>>> along
>>> with a few small changes to error message handling etc.
>>>
>>
>> In the doc snippet
>>
>> > The base64url alphabet use '-' instead of '+' and '_' instead
>> of '/' and also omits the '=' padding character.
>>
>> Should be
>>
>> > The base64url alphabet use*s* '-' instead of '+' and '_' instead of '/'*,
>> *and also omits the '=' padding character.
>>
>> I'd also add a comma before "and also"
>>
>>
>>> The base64 code this extends is the RFC 2045 variant while base64url is
>>> based
>>> on base64 from RFC 3548 (obsoleted by RFC 4648). AFAICT this is not a
>>> problem
>>> here but has anyone else verified this?
>>>
>>
>> I don't see how this can be a problem in practice.
>> The conversions are straightforward,
>> and the codepath used with url=true is a new one and doesn't change past
>> behavior.
>>
>>
>> Here’s a v6; necessary because func.sgml was split .
>> No other changes compared to v5.
>>
>
v6 introduced some whitespace errors in the regression files.
Here's a v7 that fixes that
Attachment | Content-Type | Size |
---|---|---|
v7-0001-Add-support-for-base64url-encoding-and-decoding.patch | application/octet-stream | 13.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pavel Stehule | 2025-08-06 20:16:06 | Re: event trigger support for PL/Python |
Previous Message | Tom Lane | 2025-08-06 19:11:36 | Re: headerscheck warnings with late-model gcc |