| From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: range_agg |
| Date: | 2019-07-05 17:00:15 |
| Message-ID: | CA+renyXxNMmU=0Fj-ruGZfcAAvF1QUTY5reuz4C8XiACfNSQyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 4, 2019 at 11:34 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> I noticed that this patch has a // comment about it segfaulting. Did
> you ever figure that out? Is the resulting code the one you intend as
> final?
Thanks for the review! I haven't revisited it but I'll see if I can
track it down. I consider this a WIP patch, not something final. (I
don't think Postgres likes C++-style comments, so anything that is //
marks something I consider needs more work.)
> Stylistically, the code does not match pgindent's choices very closely.
> I can return a diff to a pgindented version of your v0002 for your
> perusal, if it would be useful for you to learn its style.
Sorry about that, and thank you for making it easier for me to learn
how to do it the right way. :-)
Paul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-07-05 17:06:20 | Re: mcvstats serialization code is still shy of a load |
| Previous Message | Noah Misch | 2019-07-05 16:58:30 | Re: Fix runtime errors from -fsanitize=undefined |