| From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
|---|---|
| To: | Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix GetOperatorFromCompareType |
| Date: | 2025-11-20 16:44:57 |
| Message-ID: | CA+renyW0NUF47D7k1Z0VVuASwNTAZpvW89fEoLVOFkZOFTiNnQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 16, 2025 at 11:18 PM Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> wrote:
> After your patch changes, the line '*opid = InvalidOid;' seems removable.
>
> Also, if the second validation check of opclass after 'get_opclass_method' feels a bit odd, moving 'get_opclass_opfamily_and_input_type' to the very top would work -- purely for visual clarity. ：）
Thanks for the review! Here is a patch with your suggestions incorporated.
Yours,
--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Improve-comment-and-error-handling-in-GetOperator.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-11-20 16:59:07 | Re: Add os_page_num to pg_buffercache |
| Previous Message | Sami Imseih | 2025-11-20 16:34:14 | Re: another autovacuum scheduling thread |