| From: | Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Nitin Motiani <nitinmotiani(at)google(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Ilyasov Ian <ianilyasov(at)outlook(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Surya Poondla <s_poondla(at)apple(dot)com> |
| Subject: | Re: Inval reliability, especially for inplace updates |
| Date: | 2025-12-12 17:48:48 |
| Message-ID: | CA+renyVbRfcVcgASk_JhWL-o-WmkD64z1EUVtpYEUORuXaZ_Jw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 11, 2025 at 4:24 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
>
> On Thu, Dec 04, 2025 at 04:19:02PM -0800, Noah Misch wrote:
> > Thanks for the review.
>
> > The attached version doesn't need a comprehensive re-review, but I'd
> > particularly value hearing about any places where you find it's reducing
> > comprehensibility rather than enhancing.
>
> I'd like to get this into the back branches well in advance of the 2026-02
> releases, in case the buildfarm catches some defect at low probability. If
> there are no objections in the next week, I'll proceed that way.
I'm happy with these new comments. The explanation in
heap_inplace_lock before calling CacheInvalidateHeapTupleInplace is a
lot better I think. And removing the last param means there is less to
think about.
Thanks!
--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-12-12 18:07:08 | Re: On non-Windows, hard depend on uselocale(3) |
| Previous Message | Robert Haas | 2025-12-12 17:36:17 | Re: pg_plan_advice |