Re: GiST README typos

From: Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: GiST README typos
Date: 2025-11-06 06:36:01
Message-ID: CA+renyUiHkzvU48_K+9jMQkzN4Bx0uVv3skxKs9niB7+SENZ9Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 5, 2025 at 7:00 PM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> being empty. Whenever we find one, we acquire a lock on the parent and child
> -page, re-check that the child page is still empty. Then, we remove the
> +page, then re-check that the child page is still empty. Then, we remove the
> downlink and mark the child as deleted, and release the locks.
>
> I still find this a bit awkward -- perhaps "and re-check"? The last
> sentence could do with just the last "and" as well, I think, but
> that's a style consideration and not a grammar fix.

I nearly wrote it that way myself. It's nice that it avoids the double
"then". So I agree, let's go with "and re-check".

Thanks for the review!

Yours,

--
Paul ~{:-)
pj(at)illuminatedcomputing(dot)com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-11-06 07:16:36 Re: inconsistent tableoid handling in COPY WHERE clause
Previous Message Zhijie Hou (Fujitsu) 2025-11-06 06:33:21 RE: Assertion failure in SnapBuildInitialSnapshot()