| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
| Cc: | Euler Taveira <euler(at)timbira(dot)com(dot)br>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Create subscription with `create_slot=false` and incorrect slot name |
| Date: | 2017-05-23 08:43:45 |
| Message-ID: | CA+q6zcXQqHqhiFR-eLvVk+x9CvPLvJotyqQ77Q1U_4Uj+BLW4g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23 May 2017 at 07:26, Euler Taveira <euler(at)timbira(dot)com(dot)br> wrote:
>
> ReplicationSlotValidateName() should be called in
parse_subscription_options() to avoid a pilot error.
> IMHO we should prevent a future error (use of invalid slot name).
Yes, I see now. I assume this little patch should be enough for that.
| Attachment | Content-Type | Size |
|---|---|---|
| validate-slot-name.patch | text/x-patch | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tushar | 2017-05-23 09:00:41 | ALTER SUBSCRIPTION ..SET PUBLICATION <no name> refresh is not throwing error. |
| Previous Message | David Rowley | 2017-05-23 08:25:40 | Re: Regression in join selectivity estimations when using foreign keys |