Re: Speeding up text_position_next with multibyte encodings

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Speeding up text_position_next with multibyte encodings
Date: 2018-11-30 10:18:54
Message-ID: CA+q6zcXNNZbEehrKkPJ06MzLzou=AB2W1BGGmJp8gnYAWgEO3A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> At Fri, 19 Oct 2018 15:52:59 +0300, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote
> Attached is a patch to speed up text_position_setup/next(), in some
> common cases with multibyte encodings.

Hi,

Unfortunately, patch doesn't compile anymore due:

varlena.c: In function ‘text_position_next_internal’:
varlena.c:1337:13: error: ‘start_ptr’ undeclared (first use in this function)
Assert(start_ptr >= haystack && start_ptr <= haystack_end);

Could you please send an updated version? For now I'm moving it to the next CF.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Surafel Temesgen 2018-11-30 10:22:07 Re: FETCH FIRST clause PERCENT option
Previous Message Dmitry Dolgov 2018-11-30 10:10:15 Re: Reduce amount of WAL generated by CREATE INDEX for gist, gin and sp-gist