| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | michael(dot)banck(at)credativ(dot)de, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: Progress reporting for pg_verify_checksums |
| Date: | 2018-11-29 19:01:52 |
| Message-ID: | CA+q6zcWWpXTnOY8c5W2SRs_7pvqtKsKs1+MvwdR=MxpHF0VS-g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Wed, Oct 3, 2018 at 12:51 AM Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> wrote:
>
> On Sat, Sep 29, 2018 at 1:07 AM Michael Banck <michael(dot)banck(at)credativ(dot)de> wrote:
> > I've attached v4 of the patch.
>
> Hi Michael,
>
> Windows doesn't like sigaction:
>
> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.15189
>
> I'm not sure if we classify this as a "frontend" program. Should it
> be using pqsignal() from src/port/pqsignal.c? Or perhaps just
> sigaction as you have it (pqsignal.c says that we require sigaction on
> all Unices), but #ifndef WIN32 around that stuff, since SIGUSR1 is
> never going to work anyway.
Unfortunately, patch also has some conflicts with the current master. I'll move
it to the next CF.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-11-29 19:11:09 | Re: "SELECT ... FROM DUAL" is not quite as silly as it appears |
| Previous Message | Alexander Kuzmenkov | 2018-11-29 18:29:15 | Re: "SELECT ... FROM DUAL" is not quite as silly as it appears |