| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Date: | 2017-10-15 19:41:53 |
| Message-ID: | CA+q6zcWNs_j5pd_+j6JbFXe7M=n9NX8h0Emb1pux7Ap=w=DWrA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
> On 14 October 2017 at 12:46, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
wrote:
>
> Okay. Attached is an updated patch fixing what you have reported.
Thanks for the patch. Everything looks fine, I just have one question -
maybe
it makes sense to put this pattern `if (variadic) {/*...*/}` into a separate
function? Because from what I see it's basically one part of code (I didn't
spot any difference) repeated four times for every function.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-16 00:08:20 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Previous Message | David G. Johnston | 2017-10-15 18:23:47 | Re: BUG #14853: Parameter type is required even when the query does not need to know the type |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-10-16 00:08:20 | Re: BUG #14849: jsonb_build_object doesn't like VARIADIC calls very much |
| Previous Message | Justin Pryzby | 2017-10-15 17:08:05 | Re: SIGSEGV in BRIN autosummarize |