Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Dave Cramer <davecramer(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Vladimir Gordiychuk <folyga(at)gmail(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Reviving the "Stopping logical replication protocol" patch from Vladimir Gordichuk
Date: 2018-11-30 23:01:01
Message-ID: CA+q6zcW+ukxvTMkcGcefdfQtc0ZBD5osD_QqL3iMAx3CEDfeTw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On Mon, Nov 19, 2018 at 4:58 PM Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
>
> > On Tue, Jul 24, 2018 at 5:52 PM Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> >
> > Back in 2016 a patch was proposed that seems to have died on the vine. See https://www.postgresql.org/message-id/flat/CAFgjRd3hdYOa33m69TbeOfNNer2BZbwa8FFjt2V5VFzTBvUU3w(at)mail(dot)gmail(dot)com
> > for the history and https://commitfest.postgresql.org/10/621/ for the commitfest entry.
> > I've rebased the patches and attached them for consideration.
> > JDBC tests here https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/test/java/org/postgresql/replication/LogicalReplicationTest.java all pass
>
> Unfortunately the second patch from the series can't be applied anymore, could
> you please rebase it one more time? Other than that it looks strange for me
> that the corresponding discussion stopped when it was quite close to be in a
> good shape, bouncing from "rejected with feedback" to "needs review". Can
> someone from involved people clarify what's the current status of this patch?

Looks like I'm a failure as a neuromancer, since revival didn't happen. I'm
marking it as returned with feedback.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-30 23:03:13 Re: Add extension options to control TAP and isolation tests
Previous Message Michael Paquier 2018-11-30 23:00:16 Re: pgsql: Switch pg_verify_checksums back to a blacklist