Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] eval_const_expresisions and ScalarArrayOpExpr
Date: 2018-01-03 11:40:35
Message-ID: CA+q6zcUMq6L96UuM4g0VKeoAnGLSSQexnSZ98nDYq-hJ2hc_EQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 2 January 2018 at 20:52, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I did find one case where the patch makes things significantly slower:
>
> select * from test where true is true
> and true is true
> and true is true
> and true is true
> ... (100 times altogether)

Yes, indeed, I never tested this kind of conditions. I can confirm, this
query
is significantly slower with the previous version of the patch, but the
current
version solves this.

> I'm disinclined to change the usage of "saop" here --- that's already
> in use in lots of code touching ScalarArrayOp

Oh, ok - I see now, thank you. So, I think no one would object if I'll mark
this patch as ready for committer.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2018-01-03 12:06:38 Re: pgsql: Add parallel-aware hash joins.
Previous Message Amit Khandekar 2018-01-03 11:29:18 Re: [HACKERS] UPDATE of partition key