Re: pgbench - add \if support

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>
Cc: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgbench - add \if support
Date: 2018-01-08 17:39:49
Message-ID: CA+q6zcUCW=shzAZot_Tdmt3uOXA08cR_MfeT0V5ouh5BhOmXvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 4 January 2018 at 07:32, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
> Another rebase to try to please the patch tester.

Thanks for working on this. I had just a quick look at it, but I hope I'll have
time to post a proper review. In the meantime I'm wondering what am I doing
wrong here (I see a similar example in your first message)?

```
-- test.sql
\if random(0, 99) < 85
\set test 1
\else
\set test 2
\endif
select :test;
```

```
$ pgbench -s 10 -f test.sql
test.sql:1: unexpected character (<) in command "if"
\if random(0, 99) < 85
^ error found here
```

I'm using `pgbench-if-4.patch`, and everything is fine for simple
conditions like `\if 1`.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shubham Barai 2018-01-08 17:43:36 Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index
Previous Message Catalin Iacob 2018-01-08 17:24:21 Re: Doc tweak for huge_pages?