| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Generic type subscripting |
| Date: | 2017-09-21 15:24:17 |
| Message-ID: | CA+q6zcUA2VafRppdoR=rouWW4t=80iS=r51Pz121xNNygDNgjg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 20 September 2017 at 17:19, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
wrote:
> As a conclusion:
> * additional field are needed to pg_type for *_fetch and *_assign
functions to solve dependency problem
One last thing that I need to clarify. Initially there was an idea to
minimize
changes in `pg_type` - that's why I added only one column there that
contains an
OID of main subscripting function (and everything else you should find out
inside it). But I have no objections about adding more columns if everyone
is
ok with that. Basically pros and cons (marked as + and -):
one new column in `pg_type`:
* less intrusive (+)
* it's neccessary to make a dependency record between subscripting functions
explicitly (-)
three new columns in `pg_type`:
* more intrusive (-)
* we can create a dependency record between subscripting functions
simultaneously with a custom type creation (+)
* custom subscripting code does not need to resolve `fetch` and `assign`
functions (+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-21 15:46:40 | Re: [COMMITTERS] pgsql: Fix bool/int type confusion |
| Previous Message | Joshua D. Drake | 2017-09-21 15:05:38 | Re: SCRAM in the PG 10 release notes |