Use of pager, help, localization:

From: Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Use of pager, help, localization:
Date: 2018-10-15 19:15:20
Message-ID: CA+mi_8bR68W9t8mXpAi2NcmviDHPPYz7irokscmsOd3MFv+4YA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

From psql/help.c

/*
* Keep this line count in sync with the number of lines printed below!
* Use "psql --help=variables | wc" to count correctly; but notice that
* Windows builds currently print one more line than non-Windows builds.
* Using the larger number is fine.
*/
output = PageOutput(156, pager ? &(pset.popt.topt) : NULL);

uhm... this doesn't work at all with i10n, above all if respecting an
80 cols width.

Wouldn't be better to generate the output in a temp buffer after l10n,
count the line, then choose whether to use a pager or not?

Can provide a patch if you deem so.

-- Daniele

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-10-15 19:44:52 Re: pg11rc1 DROP INDEX: NOTICE: drop_trigger
Previous Message Justin Pryzby 2018-10-15 19:11:03 pg11rc1 DROP INDEX: NOTICE: drop_trigger