Re: Use lo_creat() when possible instead of lo_create()

From: Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>
To: Federico Di Gregorio <fog(at)dndg(dot)it>
Cc: Giovanni Mascellani <mascellani(at)poisson(dot)phc(dot)unipi(dot)it>, psycopg(at)postgresql(dot)org
Subject: Re: Use lo_creat() when possible instead of lo_create()
Date: 2012-01-10 21:57:44
Message-ID: CA+mi_8am5aixtKDTttML4Pmeds=CMfbqGOC_1+k6jCzZPKoNDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: psycopg

On Tue, Jan 10, 2012 at 12:18 PM, Daniele Varrazzo
<daniele(dot)varrazzo(at)gmail(dot)com> wrote:
> On Tue, Jan 10, 2012 at 10:06 AM, Federico Di Gregorio <fog(at)dndg(dot)it> wrote:
>> On 10/01/12 09:51, Giovanni Mascellani wrote:
>>>
>>> I just created a ticket against psycopg2, and Daniele asked me to bring
>>> the issue on the list to open it to a wider audience. The ticket is here:
>>>
>>>
>>> http://psycopg.lighthouseapp.com/projects/62710/tickets/88-use-lo_creat-when-possible-instead-of-lo_create
>>
>>
>> The patch seems fine to me. Doesn't add any overhead and improves
>> compatibility with an existing product. I vote +1 [that means "unless
>> Daniele votes -1 I'll include it" ;)]
>
> I don't know much about the difference between the two functions: if
> anybody has any interesting story about them I'd be happy to know.
> Meanwhile I'll make sure we have tests for both the code paths in the
> patch.

I've made some tests and everything seems fine. I've integrated the
patch in my branch.

-- Daniele

In response to

Browse psycopg by date

  From Date Subject
Next Message maplabs 2012-01-10 22:28:34 large return resuls
Previous Message Daniele Varrazzo 2012-01-10 11:18:23 Re: Use lo_creat() when possible instead of lo_create()