Re: BUG #6734: create table (like ...) fails if an index has a comment

From: Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ryan Kelly <rpkelly22(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6734: create table (like ...) fails if an index has a comment
Date: 2012-07-13 15:16:09
Message-ID: CA+mi_8YBWUZ8dL_do=kmK1b-ONcZs3Cn0mZGb0QTQ5Gc3ONz_Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Jul 13, 2012 at 4:11 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniele Varrazzo <daniele(dot)varrazzo(at)gmail(dot)com> writes:
>> Wouldn't it be better to call the indexes NEWTABLE_OLDINDEXNAME?
>
> Then the CREATE LIKE command would fail altogether if that name were
> already taken. Postponing the selection of the index name to the time
> when DefineIndex runs is really the only safe thing.

I've actually suggested to keep the numeric suffix to disambiguate in
case the name is already taken, as I assume the current "create like"
does. However this is not strictly related to the bug, it's more an
usability problem, so won't bother you with it anymore.

-- Daniele

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Peter Eisentraut 2012-07-13 20:52:00 Re: pg_basebackup de.po: Wrong translation
Previous Message Craig Ringer 2012-07-13 15:15:55 Re: BUG #6735: PANIC: 42501: could not open control file "global/pg_control": Permission denied