Re: ci: update to freebsd 13.1 / remove minor versions from image names

On Mon, Aug 1, 2022 at 7:43 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2022-07-28 02:57:04 -0700, Andres Freund wrote:
> > Freebsd 13.0, so far used by CI, is out of support. I've changed the
> > image to be built against 13.1, so we can switch to that.
>
> I pushed that bit.

Thanks, belated +1.

> > I suspect it'd be better to remove the minor version numbers from the
> > image name, so that switches from 13.0 -> 13.1 don't require CI
> > changes. Any argument against?

Yeah, that makes sense; it'd remove the need for commits like that.
For comparison, the Debian image is Bullseye AKA 11.x without the x in
the name.

> > I can also see an argument for not having 13 in the image name, given
> > that the image is CI specific anyway? But perhaps we might want to have
> > a 13 and a 14 image for some debugging issue?

I'm not sure about this. I could imagine a naming scheme that has
sensible options available as pg-ci-{debian,freebsd,...}-default, and
those images are currently the same as
pg-ci-{debian-11,freebsd-13,...} but can be re-pointed as appropriate
without having to modify the .cirrus.yml, and someone investigating a
problem where they really care about the major version could change
their .cirrus.yml to point to the versioned name. And likewise for
Windows containers; I'm not sure I understand how Cirrus's macOS
images work, but maybe there too. The problem would be if, for some
reason, you finish up needing to synchronise a change between the
.cirrus.yml file and the image (like, you need to run slightly
different commands for the build or something). I don't have a
concrete example, but I have a strange feeling in my big toe that it'd
be better to state the major version explicitly, and have a few
available...