Re: Invisible PROMPT2

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Maxence Ahlouche <maxence(dot)ahlouche(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Invisible PROMPT2
Date: 2020-02-10 00:30:39
Message-ID: CA+hUKGLyfaPyF=-07yQKG3jsMr96HpZYUyAJmaN9SKUay3T8rg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 23, 2019 at 5:43 AM Maxence Ahlouche
<maxence(dot)ahlouche(at)gmail(dot)com> wrote:
> On Wed, 27 Nov 2019 at 17:09, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Good idea, but I think you need to account for "visible" (ie, if the
>> newline is inside RL_PROMPT_START_IGNORE, it shouldn't change the width).
>> It might be best to add logic inside the existing "if (visible)" instead
>> of making a new top-level case.
>
> Right, I assumed that it was safe given that only terminal control characters were invisible.
> Since the title of the terminal window can be changed as well via control characters, it's probably better not to make that assumption.
>
> I updated the patch accordingly.

Pushed. Thanks!

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-02-10 00:45:49 Re: Add %x to PROMPT1 and PROMPT2
Previous Message tsunakawa.takay@fujitsu.com 2020-02-10 00:23:15 RE: Internal key management system