| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: First-draft release notes for back branches are up |
| Date: | 2019-05-04 03:56:24 |
| Message-ID: | CA+hUKGLsNqm=axs-mmzym9bbXMo=CV-F0_7f68jQYXb67kaBSQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 4, 2019 at 1:29 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > On Sat, May 4, 2019 at 10:29 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > + Tolerate <literal>EINVAL</literal> and <literal>ENOSYS</literal>
> > + error results, where appropriate, for fsync calls (Thomas Munro,
> > + James Sewell)
>
> > Nit-picking: ENOSYS is for sync_file_range, EINVAL is for fsync.
>
> Yeah, I didn't really think it was worth distinguishing. If there
> is some more general term that covers both calls, maybe we should
> use that?
I would just do s/fsync/fsync and sync_file_range/. And I guess also
wrap them in <function>?
--
Thomas Munro
https://enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronny Ko | 2019-05-04 05:32:06 | Logging the feature of SQL-level read/write commits |
| Previous Message | Euler Taveira | 2019-05-04 03:11:32 | Re: improving wraparound behavior |