| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Preallocate some DSM space at startup. |
| Date: | 2020-07-31 07:12:50 |
| Message-ID: | CA+hUKGLrmN9Mz3K4q58rxhuhirr_9dXFBs5rvGT59Q15ZvYfeQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Jul 31, 2020 at 6:26 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> longfin is complaning on this one:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=longfin&dt=2020-07-31%2005%3A59%3A08
> guc.c:2241:38: error: implicit conversion from 'unsigned long' to
> 'int' changes value from 17592186044415 to -1
> [-Werror,-Wconstant-conversion]
> 0, 0, Min(INT_MAX, SIZE_MAX / 1024 / 1024),
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
Thanks. I pushed a fix after checking on Clang 11 and GCC 8 that it's
warning-free and produces the value I want on 32 and 64 bit builds.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-07-31 15:43:50 | pgsql: Fix recently-introduced performance problem in ts_headline(). |
| Previous Message | Thomas Munro | 2020-07-31 07:10:34 | pgsql: Fix compiler warning from Clang. |