| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Shawn Debnath <sdn(at)amazon(dot)com> |
| Subject: | Re: checkpointer: PANIC: could not fsync file: No such file or directory |
| Date: | 2019-12-13 04:41:56 |
| Message-ID: | CA+hUKGLqob8hOCnh=oodnsi7Fm7dyeXy0pyyS+hSZF8Lp3gO7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 30, 2019 at 10:57 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Fri, Nov 29, 2019 at 12:34 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > ... or stop using
> > _mdfd_getseg() for this so that you can remove segments independently
> > without worrying about sync requests for other segments (it was
> > actually like that in an earlier version of the patch for commit
> > 3eb77eba, but someone complained that it didn't benifit from fd
> > caching).
>
> Not sure which approach I prefer yet, but here's a patch showing that
> alternative.
Here's a better version: it uses the existing fd if we have it already
in md_seg_fds, but opens and closes a transient one if not.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-use-_mdfd_getseg-in-mdsyncfiletag-v2.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2019-12-13 05:01:24 | Re: get_database_name() from background worker |
| Previous Message | Masahiko Sawada | 2019-12-13 04:33:13 | Re: [HACKERS] Block level parallel vacuum |