Re: pg_upgrade test failure

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: pg_upgrade test failure
Date: 2023-01-31 01:00:05
Message-ID: CA+hUKGLfruDhC_8QRGDoCndsdzDVjrf7TYwgsv+OfoAmK2syEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Jan 5, 2023 at 4:11 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Wed, Dec 7, 2022 at 7:15 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On 2022-11-08 01:16:09 +1300, Thomas Munro wrote:
> > > So [1] on its own didn't fix this. My next guess is that the attached
> > > might help.
>
> > What is our plan here? This afaict is the most common "false positive" for
> > cfbot in the last weeks.

I pushed the rmtree() change. Let's see if that helps, or tells us
something new.

Michael: There were some questions from Andres above. FWIW I think
if you wanted to investigate this properly on a local Windows system
to chase down who's got the file open (shutdown sequence problem or
whatever), you'd probably have to install Server 2019, or maybe use an
old 8.1 VM if you still have such a thing, based on the suspicion that
typical 10 and 11 systems won't exhibit the problem. But then I could
be wrong about what's going on...

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-01-31 03:47:55 pgsql: Remove recovery test 011_crash_recovery.pl
Previous Message Thomas Munro 2023-01-31 00:49:58 pgsql: Refactor rmtree() to use get_dirent_type().

Browse pgsql-hackers by date

  From Date Subject
Next Message Anton A. Melnikov 2023-01-31 01:09:58 Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"
Previous Message Robins Tharakan 2023-01-31 00:34:58 Re: postgres_fdw uninterruptible during connection establishment / ProcSignalBarrier