Outdated comments about proc->sem in lwlock.c

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Outdated comments about proc->sem in lwlock.c
Date: 2021-03-09 12:11:59
Message-ID: CA+hUKGLafjB1uzXcy==2L3cy7rjHkqOVn7qRYGBjk==tMJE7Yg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

In passing I noticed that lwlock.c contains 3 comments about bogus
wakeups due to sharing proc->sem with the heavyweight lock manager and
ProcWaitForSignal. Commit 6753333f55e (9.5) switched those things
from proc->sem to proc->procLatch. ProcArrayGroupClearXid() and
TransactionGroupUpdateXidStatus() also use proc->sem though, and I
haven't studied how those might overlap with with LWLockWait(), so I'm
not sure what change to suggest.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-03-09 12:16:10 Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[]
Previous Message houzj.fnst@fujitsu.com 2021-03-09 11:54:04 Questions about CommandIsReadOnly