From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgindent vs variable declaration across multiple lines |
Date: | 2023-01-22 23:47:01 |
Message-ID: | CA+hUKGLVaG6sWhO2gZoapkOL4sAK7QOEtJ-TSB-uZxLvb6XkCA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jan 23, 2023 at 11:34 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I spent some more time staring at this and came up with what seems like
> a workable patch, based on the idea that what we want to indent is
> specifically initialization expressions. pg_bsd_indent does have some
> understanding of that: ps.block_init is true within such an expression,
> and then ps.block_init_level is the brace nesting depth inside it.
> If you just enable ind_stmt based on block_init then you get a bunch
> of unwanted additional indentation inside struct initializers, but
> it seems to work okay if you restrict it to not happen inside braces.
> More importantly, it doesn't change anything we don't want changed.
Nice! LGTM now that I know about block_init.
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2023-01-22 23:52:18 | Re: run pgindent on a regular basis / scripted manner |
Previous Message | Tom Lane | 2023-01-22 23:28:27 | Re: run pgindent on a regular basis / scripted manner |