| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Rationalize GetWalRcv{Write,Flush}RecPtr(). |
| Date: | 2020-05-02 03:53:20 |
| Message-ID: | CA+hUKGLTEXkr+Q_APSC7jhifOSib8J2cT4FzJzQ4G2viyt3Qpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Apr 16, 2020 at 9:24 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> On 2020-Apr-09, Alvaro Herrera wrote:
> > It seems worth pointing out that the new GetWalRcvWriteRecPtr function
> > has a different signature from the original one -- so any third-party
> > code using the original function will now get a compile failure that
> > should alert them that they need to change their code to call
> > GetWalRcvFlushRecPtr instead. Maybe we should add a line or two in the
> > comments GetWalRcvWriteRecPtr to make this explicit.
>
> After using codesearch.debian.net and finding no results, I decided that
> this is not worth the effort.
Thanks for checking. Yeah, it looks like you're right.
codesearch.debian.net is cool.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-05-02 08:47:37 | pgsql: Add NLS to pg_verifybackup |
| Previous Message | Tomas Vondra | 2020-05-01 23:35:14 | pgsql: Remove pg_xact entry from SLRU stats |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2020-05-02 06:56:07 | Re: SLRU statistics |
| Previous Message | Michael Paquier | 2020-05-02 02:46:06 | Rotten parts of src/backend/replication/README |