On Mon, Mar 15, 2021 at 6:14 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Mon, Mar 15, 2021 at 9:54 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > While reviewing the patch for parallel REFRESH MATERIALIZED VIEW, I
> > noticed that select_parallel.sql and write_parallel.sql believe that
> > (1) the tests are supposed to work with serializable as a default
> > isolation level, and (2) parallelism would be inhibited by that, so
> > they'd better use something else explicitly. Here's a patch to update
> > that second thing in light of commit bb16aba5. I don't think it
> > matters enough to bother back-patching it.
>
> +1, patch basically LGTM. I have one point - do we also need to remove
> "begin isolation level repeatable read;" in aggreates.sql, explain.sql
> and insert_parallel.sql? And in insert_parallel.sql, the comment also
> says "Serializable isolation would disable parallel query", which is
> not true after bb16aba5. Do we need to change that too?
Yeah, you're right. That brings us to the attached.