Re: Collation versioning

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Douglas Doole <dougdoole(at)gmail(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Collation versioning
Date: 2020-03-11 03:13:17
Message-ID: CA+hUKGLEJwpEfPbX7P=ujQnBwduo6eaN+UuJu+zQTHN+VWruqA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 4, 2020 at 10:01 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> On Thu, Feb 27, 2020 at 08:45:35AM +0100, Julien Rouhaud wrote:
> > On Thu, Feb 27, 2020 at 04:10:14PM +1300, Thomas Munro wrote:
> > > On Thu, Feb 27, 2020 at 3:29 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> > > > [v10]
> > [...]
> >
> > Fixed in v11 by changing pg_collation_actual_version() to handle default
> > collation too, as it seems a better behavior.
>
> Rebased v12 due to conflict with the recent command tag commit (2f9661311b), no
> other changes.

I'm still reviewing and testing the code, but here's a new patch set
with a bunch of small changes to documentation, tests and commit
messages:

0001-Remove-pg_collation.collversion-v13.patch
* removed ALTER COLLATION ... REFRESH VERSION from the docs
* removed ALTER COLLATION ... REFRESH VERSION from collate.linux.utf8.sql
(oops, that wasn't running on my FreeBSD system, or on cfbot's Ubuntu
image because it doesn't have "locales-all" installed; I will make a
note to fix that on cfbot)

0002-Add-pg_depend.refobjversion-v13.patch
* added new column to the documentation of the pg_depend catalog

0003-Implement-type-regcollation-v13.patch
* added regcollation to a list of such types in datatype.sgml

0004-Track-collation-versions-for-indexes-v13.patch
* added a note to the documentation's list of reasons why REINDEX
might be needed

0005-Preserve-index-dependencies-on-collation-during--v13.patch
* minor rewording of the docs, I hope you like it

0006-Add-ALTER-INDEX-.-ALTER-COLLATION-.-REFRESH-VERS-v13.patch
* minor rewording of the docs, I hope you like it

0007-doc-Add-Collation-Versions-section-v13.patch
* new: a brief introduction to this topic

Attachment Content-Type Size
0001-Remove-pg_collation.collversion-v13.patch text/x-patch 26.7 KB
0002-Add-pg_depend.refobjversion-v13.patch text/x-patch 12.5 KB
0003-Implement-type-regcollation-v13.patch text/x-patch 9.4 KB
0004-Track-collation-versions-for-indexes-v13.patch text/x-patch 62.4 KB
0005-Preserve-index-dependencies-on-collation-during--v13.patch text/x-patch 38.6 KB
0006-Add-ALTER-INDEX-.-ALTER-COLLATION-.-REFRESH-VERS-v13.patch text/x-patch 14.5 KB
0007-doc-Add-Collation-Versions-section-v13.patch text/x-patch 2.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2020-03-11 03:25:28 [PATCH] Skip llvm bytecode generation if LLVM is missing
Previous Message Masahiko Sawada 2020-03-11 03:00:41 Re: Berserk Autovacuum (let's save next Mandrill)