Move syncscan.c?

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Move syncscan.c?
Date: 2020-06-23 01:30:39
Message-ID: CA+hUKGLCnG=NEAByg6bk+CT9JZD97Y=AxKhh27Su9FeGWOKvDg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

It's a bit odd that syncscan.c is used by both heapam.c and tableam.c,
and provides a generic block-synchronization mechanism that other
table AMs might want to use too, but it lives under
src/backend/access/heap. It doesn't actually do anything heap
specific (beyond being block-oriented), and it's weird that tableam.c
has to include heapam.h.

Perhaps we should move the .c file under src/backend/access/table, as attached.

I suppose it's remotely possible that someone might invent
physical-order index scans, and once you have those you might sync
scans of those too, and then even table would be too specific, but
that may be a bit far fetched.

Attachment Content-Type Size
0001-Move-syncscan.c-to-src-backend-access-table.patch text/x-patch 6.1 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-06-23 01:40:36 Re: pg_regress cleans up tablespace twice.
Previous Message Michael Paquier 2020-06-23 01:18:43 Re: [PATCH] Allow to specify restart_lsn in pg_create_physical_replication_slot()