| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: pgbench: Refactor thread portability support. |
| Date: | 2021-03-10 07:14:18 |
| Message-ID: | CA+hUKGL8xub3GNv6ZQYoZEpSCbXDtsnHOyNWiKiS2yDF-t2d+A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Mar 10, 2021 at 8:10 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Mar 10, 2021 at 04:52:01AM +0000, Thomas Munro wrote:
> > pgbench: Refactor thread portability support.
> >
> > Instead of maintaining an incomplete emulation of POSIX threads for
> > Windows, let's use an extremely minimalist macro-based abstraction for
> > now. A later patch will extend this, without the need to supply more
> > complicated pthread emulation code. (There may be a need for a more
> > serious portable thread abstraction in later projects, but this is not
> > it.)
>
> This one is causing a failure in whelk:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2021-03-10%2006%3A41%3A53
> src/bin/pgbench/pgbench.c(6154): warning C4024: '_beginthreadex' :
> different types for formal and actual parameter 3 [C:\\buildfarm\\buildenv\\HEAD\\pgsql.build\\pgbench.vcxproj]
Thanks, looking at this and the others.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-03-10 07:17:21 | pgsql: Small debug message tweak |
| Previous Message | Michael Paquier | 2021-03-10 07:10:02 | Re: pgsql: pgbench: Refactor thread portability support. |