| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-hackers(at)postgresql(dot)org, Ants Aasma <ants(at)cybertec(dot)at> |
| Subject: | Re: ReadRecentBuffer() doesn't scale well |
| Date: | 2025-09-18 23:44:25 |
| Message-ID: | CA+hUKGL+c9LYZX2TZ2Wt=HxmQCHGxp4aDo-BJqL-3ZXGY1MOQA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 19, 2025 at 12:36 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> I'm planning to commit 0001 soon, unless you'd like to do the honors - I would
> break it with some upcoming patches, and it's a good improvement. Those
> patches also will PinBuffer_Locked() a bit slower, i.e. it'd be good to avoid
> using it in ReadRecentBuffer() for that reason alone.
Oh, thanks for thinking about that interaction. I'll go ahead and
push it later today after I re-convince myself that it's correct.
> > XXX This also fixes ReadRecentBuffer()'s failure to bump the usage
> > count. Fix separately or back-patch this?
>
> FWIW, I'm inclined to not backpatch the usagecount change at this
> point. Unless we have a clear case where it really hurts, I'm more worried
> about disturbing working workloads...
+1
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Chao Li | 2025-09-18 23:41:14 | Re: fix obsolete references to postgres.h in comments |