From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: POC: Cleaning up orphaned files using undo logs |
Date: | 2019-07-17 03:56:29 |
Message-ID: | CA+hUKGKzMS-jw2k0TjerdLU4=01aRQNsTshK7NP5TM3aa0UQWA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 17, 2019 at 3:44 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> Right, actually I got that point. But, I was thinking that we are
> wasting one logno from undo log addressing space no?. Instead, if we
> can keep it attached to the slot and somehow manage to add to the free
> list then the same logno can be used by someone else?
We can never reuse log numbers. UndoRecPtr values containing that log
number could exist in permanent storage anywhere (zheap, zedstore etc)
and must appear to be discarded forever if anyone asks. Now, it so
happens that the current coding in zheap has fxid + urp for each
transaction slot and always checks the fxid first so it probably
wouldn't ask about discarded urps too much, but I don't think that's
policy is a requirement and the undo layer can't count on it. I think
I heard that zedstore is planning to check urp only.
--
Thomas Munro
https://enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2019-07-17 04:07:14 | psql ctrl+f skips displaying of one record and displays skipping one line |
Previous Message | Dilip Kumar | 2019-07-17 03:44:37 | Re: POC: Cleaning up orphaned files using undo logs |