| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Shawn Debnath <sdn(at)amazon(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactoring the checkpointer's fsync request queue |
| Date: | 2019-04-04 04:39:14 |
| Message-ID: | CA+hUKGKwjTgaBF020sJ+MuEcWcOubmuoaS36xpJfWxuPY6AMpA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 4, 2019 at 5:36 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2019-04-03 21:19:45 -0700, Shawn Debnath wrote:
> > +typedef struct FileTag
> > +{
> > + int16 handler; /* SyncRequstHandler value, saving space */
> > + int16 forknum; /* ForkNumber, saving space */
> > + RelFileNode rnode;
> > + BlockNumber segno;
> > +} FileTag;
>
> Seems odd to me to use BlockNumber for segno.
That is a tradition in md.c code. I had a new typedef SegmentNumber
in all sync.{c,h} stuff in an earlier version, but had trouble
figuring out where to define it...
--
Thomas Munro
https://enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2019-04-04 04:49:36 | Retronym: s/magnetic disk/main data/ |
| Previous Message | Tsunakawa, Takayuki | 2019-04-04 04:37:59 | RE: Speed up transaction completion faster after many relations are accessed in a transaction |