| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: fixing old_snapshot_threshold's time->xid mapping |
| Date: | 2020-08-14 00:52:29 |
| Message-ID: | CA+hUKGKu9CriRL0ow0K=2KD==TsHOsgHcTxt1agZqdYwTHTAXA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 22, 2020 at 5:39 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> - if (ts == update_ts)
> + if (ts >= update_ts)
Hi Dilip, I didn't follow this bit -- could you explain?
Here's a rebase. In the 0004 patch I chose to leave behind some
unnecessary braces to avoid reindenting a bunch of code after removing
an if branch, just for ease of review, but I'd probably remove those
in a committed version. I'm going to add this stuff to the next CF so
we don't lose track of it.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Expose-oldSnapshotControl.patch | text/x-patch | 6.7 KB |
| v6-0002-contrib-old_snapshot-time-xid-mapping.patch | text/x-patch | 7.9 KB |
| v6-0003-Fix-bugs-in-MaintainOldSnapshotTimeMapping.patch | text/x-patch | 2.6 KB |
| v6-0004-Rewrite-the-snapshot_too_old-tests.patch | text/x-patch | 28.2 KB |
| v6-0005-Truncate-snapshot-too-old-time-map-when-CLOG-is-t.patch | text/x-patch | 6.8 KB |
| v6-0006-Add-TAP-test-for-snapshot-too-old-time-map-mainte.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-08-14 00:53:46 | Re: pg_dump from v13 is slow |
| Previous Message | Tom Lane | 2020-08-14 00:47:28 | Re: security_context_t marked as deprecated in libselinux 3.1 |