| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Banck <mbanck(at)gmx(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Dead code in ps_status.c |
| Date: | 2025-11-17 22:24:40 |
| Message-ID: | CA+hUKGKt0JavEGD-P27rQwXYKAccCWXr=K+xTLHcoDrsuzydTg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 17, 2025 at 10:36 PM Michael Banck <mbanck(at)gmx(dot)net> wrote:
> I mentioned that in a follow-up[0] to my original mail that you
> apparently did not see eiter:
>
> |By the way, on the back branches from 13-15 (before the above commit)
> |process title changes don't work either, presumably because __hurd__ (as
> |opposed to __GNU__ and __gnu_hurd__) has not been defined on GNU/Hurd
> |for ages (or ever?), see
> |https://github.com/gcc-mirror/gcc/blob/master/gcc/config/gnu.h#L25
> |
> |So in case this get backpatched, I think it should be changed to
> |PS_USE_CLOBBER_ARGV there as well.
>
> So yeah, I think those would be useful to fix. If you have a patch, I am
> happy to test it, or I can come up with one (but not sure I manage this
> week).
Ahh, yeah, I'd missed that one too. The mail is definitely getting
through now, though.
With that information, it seemed pretty clear what to do, so I went
ahead and back-patched to 14 and 15.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-11-17 22:26:55 | Re: vacuumdb: add --dry-run |
| Previous Message | Nathan Bossart | 2025-11-17 22:16:48 | Re: Speed up COPY FROM text/CSV parsing using SIMD |