From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
---|---|
To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pg_tablespace_location() failure with allow_in_place_tablespaces |
Date: | 2022-03-15 01:33:17 |
Message-ID: | CA+hUKGKqPgU=pLUinnqN5qsPS2d3X4XXnYpCuphK2Hwpq03DRA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 8, 2022 at 4:01 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> At Tue, 8 Mar 2022 10:28:46 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> > On Tue, Mar 08, 2022 at 10:06:50AM +0900, Kyotaro Horiguchi wrote:
> > > At Tue, 8 Mar 2022 10:39:06 +1300, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote in
> > >> Thanks, you're right. Test on a Win10 VM. Here's a new version.
> >
> > Looks fine to me.
> >
> > > FYI, on Windows11, pg_basebackup didn't work correctly without the
> > > patch. So this looks like fixing an undiscovered bug as well.
> >
> > Well, that's not really a long-time bug but just a side effect of
> > in-place tablespaces because we don't use them in many test cases
> > yet, is it?
>
> No, we don't. So just FYI.
Ok, I pushed the fix for pg_basebackup.
As for the complaint about pg_tablespace_location() failing, would it
be better to return an empty string? That's what was passed in as
LOCATION. Something like the attached.
Attachment | Content-Type | Size |
---|---|---|
fix.patch | text/x-patch | 1017 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | kuroda.hayato@fujitsu.com | 2022-03-15 01:39:49 | RE: Handle infinite recursion in logical replication setup |
Previous Message | lupeng | 2022-03-15 01:31:19 | Change the csv log to 'key:value' to facilitate the user to understanding and processing of logs |