| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A micro-optimisation for walkdir() |
| Date: | 2020-09-04 23:15:07 |
| Message-ID: | CA+hUKGKheopqQSFOWLY4hAqcRf0P=VvMdXEyzkVVvw6U3K50JA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Sep 5, 2020 at 9:45 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2020-09-02 17:51:27 +0200, Juan José Santamaría Flecha wrote:
> > + attrib = GetFileAttributes(d->ret.d_name);
>
> Is this really an optimization? The benefit of Thomas' patch is that
> that information sometimes already is there. But here you're doing a
> separate lookup with GetFileAttributes()?
Well as discussed already, our stat() emulation on Windows does
multiple syscalls, so it's a slight improvement. However, it looks
like we might be missing a further opportunity here... Doesn't
Windows already give us the flags we need in the dwFileAttributes
member of the WIN32_FIND_DATA object that the Find{First,Next}File()
functions populate?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2020-09-05 00:05:52 | Re: WIP: WAL prefetch (another approach) |
| Previous Message | Alvaro Herrera | 2020-09-04 21:52:54 | Re: A micro-optimisation for walkdir() |