| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
| Subject: | Re: Calling PGReserveSemaphores() from CreateOrAttachShmemStructs |
| Date: | 2025-08-25 09:40:53 |
| Message-ID: | CA+hUKGKc8AuypHmGFm8prbC=Q0_1Ley3pBNLNikD28+sLzqtpQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 25, 2025 at 9:10 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> Is this change correct? Was there any reason to leave it like that in
> e25626677f8076eb3ce94586136c5464ee154381? Or was it just something
> that didn't fit in that commit?
We/I just missed that opportunity when ripping that stuff out. It
sounds like we might need a comment-only patch to back-patch to 18
that would say something like "this is done here for historical
reasons" so as not to confuse people with obsolete nonsense, and a
follow up patch for master to do things in a more straightforward way
as you said.
> If the change looks safe and useful, I will create CF entry for it so
> that the patch gets tested on all platforms, and thus with different
> definitions of PGReserveSemaphores().
+1, will review, thanks!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-08-25 10:43:11 | RE: [Patch] add new parameter to pg_replication_origin_session_setup |
| Previous Message | Peter Eisentraut | 2025-08-25 09:36:28 | Re: Generate GUC tables from .dat file |